Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: 1/n legacy accelerators and plugins #5645

Merged
merged 14 commits into from
Jan 27, 2021
Merged

Refactor: 1/n legacy accelerators and plugins #5645

merged 14 commits into from
Jan 27, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 25, 2021 •
edited
Loading

What does this PR do?

moving actual accelerators and plugins to its legacy sub-package to not interfere with the new structure
This is the initial step for #5616

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Jan 25, 2021
@Borda Borda added this to the 1.2 milestone Jan 25, 2021
@Borda Borda self-assigned this Jan 25, 2021
@Borda Borda marked this pull request as draft January 25, 2021 11:07
@Borda Borda mentioned this pull request Jan 25, 2021
Closed
16 tasks
@Borda Borda marked this pull request as ready for review January 25, 2021 13:45
@Borda Borda added the ready PRs ready to be merged label Jan 25, 2021
@Borda Borda enabled auto-merge (squash) January 25, 2021 14:53
@mergify mergify bot removed the has conflicts label Jan 26, 2021
@tchaton tchaton changed the title Refactor: legacy accelerators and plugins Refactor: 1/n legacy accelerators and plugins Jan 26, 2021
tchaton
tchaton approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

carmocca
carmocca reviewed Jan 26, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jan 26, 2021
@Borda Borda requested a review from carmocca January 26, 2021 12:43
@mergify mergify bot removed the has conflicts label Jan 26, 2021
@Borda Borda merged commit 7e2e874 into release/1.2-dev Jan 27, 2021
@Borda Borda deleted the refactor/legacy-accel-plug branch January 27, 2021 01:04
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #5645 (bbbe7c6) into release/1.2-dev (9d165f6) will decrease coverage by 3%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           release/1.2-dev   #5645     +/-   ##
=================================================
- Coverage               93%     89%     -3%     
=================================================
  Files                  154     163      +9     
  Lines                11040   12070   +1030     
=================================================
+ Hits                 10216   10795    +579     
- Misses                 824    1275    +451

@justusschock justusschock mentioned this pull request Feb 2, 2021
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

@s-rog s-rog Awaiting requested review from s-rog

Assignees

@Borda Borda

Labels
ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Borda @awaelchli @SeanNaren @carmocca @tchaton @justusschock